On Tue, Nov 19, 2019 at 02:31:30PM -0800, Eric Biggers wrote:
> +# Require support for adding a key to a filesystem's fscrypt keyring via an
> +# "fscrypt-provisioning" keyring key.
> +_require_add_enckey_by_key_id()
> +{
> + local mnt=$1
> +
> + # Userspace support
> + _require_xfs_io_command "add_enckey" "-k"
> +
> + # Kernel support
> + if $XFS_IO_PROG -c "$add_enckey -k 12345 $mnt" \
> + |& grep -q 'Invalid argument'; then
> + _notrun "Kernel doesn't support key_id parameter to FS_IOC_ADD_ENCRYPTION_KEY"
> + fi
> +}
There's a bug here that makes the test not be skipped when it should.
It should say:
if $XFS_IO_PROG -c "add_enckey -k 12345" "$mnt" \
I'll fix this in the next version.
- Eric
|