On Mon, Aug 19 2019 at 10:17am -0400,
Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote:
> Replace the explicit ESSIV handling in the dm-crypt driver with calls
> into the crypto API, which now possesses the capability to perform
> this processing within the crypto subsystem.
>
> Note that we reorder the AEAD cipher_api string parsing with the TFM
> instantiation: this is needed because cipher_api is mangled by the
> ESSIV handling, and throws off the parsing of "authenc(" otherwise.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
I really like to see this type of factoring out to the crypto API;
nicely done.
Acked-by: Mike Snitzer <snitzer@xxxxxxxxxx>
Herbert, please feel free to pull this, and the next 6/6 patch, into
your crypto tree for 5.4. I see no need to complicate matters by me
having to rebase my dm-5.4 branch ontop of the crypto tree, etc.
Thanks,
Mike
|