Re: [PATCH] fscrypt: remove WARN_ON_ONCE() when decryption fails

"Theodore Ts'o" <tytso@xxxxxxx> · Tue, 16 Apr 2019 18:45:24 -0400

On Fri, Mar 15, 2019 at 02:16:32PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> If decrypting a block fails, fscrypt did a WARN_ON_ONCE().  But WARN is
> meant for kernel bugs, which this isn't; this could be hit by fuzzers
> using fault injection, for example.  Also, there is already a proper
> warning message logged in fscrypt_do_page_crypto(), so the WARN doesn't
> add much.
> 
> Just remove the unnessary WARN.
> 
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

Looks good, applied.

					- Ted