On Tue, Mar 14, 2017 at 05:25:51PM -0700, Eric Biggers wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > Add a test which revokes a keyring key while other processes are > performing I/O on an encrypted file that was "unlocked" using that key. > This crashes unpatched kernels with filesystem encryption enabled, so > place it in the "dangerous" group. > > [The patch to fix this is titled "fscrypt: remove broken support for > detecting keyring key revocation" but hasn't been merged yet; we may > want to wait a bit before merging this test.] Agreed. > > Cc: Theodore Ts'o <tytso@xxxxxxx> > Cc: Jaegeuk Kim <jaegeuk@xxxxxxxxxx> > Cc: Richard Weinberger <richard@xxxxxx> > Cc: Michael Halcrow <mhalcrow@xxxxxxxxxx> > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> This looks good to me, and it crashed my 4.11-rc2 test host very quickly. Just one minor comment below. > --- > common/encrypt | 8 ++++ > tests/generic/500 | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++ > tests/generic/500.out | 2 + > tests/generic/group | 1 + > 4 files changed, 120 insertions(+) > create mode 100755 tests/generic/500 > create mode 100644 tests/generic/500.out ... > +# remove previous $seqres.full before test > +rm -f $seqres.full > + > +# real QA test starts here > +_supported_fs ext4 f2fs supported fs should be generic if it's in generic dir. If it only supports some specific filesystems, then it should go to shared dir. Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe linux-fscrypt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html