On Tue, 2024-04-23 at 22:31 +0800, Xu Yilun wrote: > On Tue, Apr 09, 2024 at 07:39:39PM -0400, Peter Colberg wrote: > > This change separates out most of the symbol name changes required by this > > patch series for the file: drivers/fpga/dfl-afu-main.c. This is done to > > split a single monolithic change into multiple, smaller patches at the > > request of the maintainer. > > > > Signed-off-by: Peter Colberg <peter.colberg@xxxxxxxxx> > > --- > > v2: > > - Split monolithic patch into series at request of maintainer > > - Change afu_ioctl_*() to receive dfl_feature_dev_data instead of > > dfl_feature_platform_data. > > - Replace local variable pdata with fdata in afu_mmap(). > > - Remove unused local variable pdata in afu_dev_{init,destroy}(). > > --- > > drivers/fpga/dfl-afu-main.c | 110 ++++++++++++++++++------------------ > > 1 file changed, 56 insertions(+), 54 deletions(-) > > > > diff --git a/drivers/fpga/dfl-afu-main.c b/drivers/fpga/dfl-afu-main.c > > index 6b97c073849e..61868cdd5b0b 100644 > > --- a/drivers/fpga/dfl-afu-main.c > > +++ b/drivers/fpga/dfl-afu-main.c > > @@ -504,9 +504,11 @@ static const struct attribute_group port_afu_group = { > > static int port_afu_init(struct platform_device *pdev, > > struct dfl_feature *feature) > > { > > + struct dfl_feature_dev_data *fdata = > > + to_dfl_feature_dev_data(&pdev->dev); > > struct resource *res = &pdev->resource[feature->resource_index]; > > > > - return afu_mmio_region_add(dev_get_platdata(&pdev->dev), > > + return afu_mmio_region_add(fdata, > > Again, please keep the change simple for massive replacement. If you > want other adjustments, do it in another patch. This is now prepared in "fpga: dfl: pass feature platform data instead of device as argument" followed by the pdata -> fdata replacement in "fpga: dfl: refactor functions to take/return feature device data". Thanks, Peter > > Thanks, > Yilun