On 8/20/24 01:51, Philipp Stanner wrote: > The function pcim_iounmap_regions() is problematic because it uses a > bitmask mechanism to release / iounmap multiple BARs at once. It, thus, > prevents getting rid of the problematic iomap table mechanism which was > deprecated in commit e354bb84a4c1 ("PCI: Deprecate pcim_iomap_table(), > pcim_iomap_regions_request_all()"). > > Make pcim_iounmap_region() public as the successor of > pcim_iounmap_regions(). > > Signed-off-by: Philipp Stanner <pstanner@xxxxxxxxxx> Looks fine, but as commented on patch 1, I think this would look better squashed with patch 1. Anyway: Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx> -- Damien Le Moal Western Digital Research