Re: [PATCH 1/2] fpga: socfpga: use 'time_left' variable with wait_for_completion_interruptible_timeout()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yilun,

> Sorry for late reply.

No worries, thank you for the review.

> First of all, please limit your subject/shortlog/summary within 70
> chars.

I'll try but it will be hard when it contains such a long function name.

> > There is a confusing pattern in the kernel to use a variable named 'timeout' to
> 
> Please make the changelog line wrapped at less than 75 chars.

Good point. My scripts reformat generated paragraphs now accordingly.

> > +	int ret = 0;
> > +	long time_left;
> 
> Please use reverse xmas tree when it is easy to follow.

Will fix.

All the best,

   Wolfram

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux