On Fri, Apr 26, 2024 at 09:35:07PM +0000, Colberg, Peter wrote: > On Fri, 2024-04-26 at 12:10 +0800, Xu Yilun wrote: > > On Mon, Apr 22, 2024 at 07:02:57PM -0400, Peter Colberg wrote: > > > Add PCI subdevice ID for the Intel D5005 Stratix 10 FPGA card as > > > used with the Open FPGA Stack (OFS) FPGA Interface Manager (FIM). > > > > > > Unlike the Intel D5005 PAC FIM which exposed a separate PCI device ID, > > > the OFS FIM reuses the same device ID for all DFL-based FPGA cards > > > and differentiates on the subdevice ID. The subdevice ID values were > > > chosen as the numeric part of the FPGA card names in hexadecimal. > > > > > > Link: https://github.com/OFS/dfl-feature-id/pull/4 > > > > Any reason to put the Link in changelog. I didn't see it provide any > > extra info. > > The link is provided to point to the corresponding change in the dfl- > pci-ids registry, for someone who might not be aware of its existence. I suggest you don't put it in changelog, few people care about this downstream history. Put it below '---' if really necessary. I deleted this link when apply. Thanks, Yilun