Re: [PATCH] fpga: altera-ps-spi: Use spi_get_device_match_data()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 7, 2023 at 2:56 AM Xu Yilun <yilun.xu@xxxxxxxxxxxxxxx> wrote:
>
> On Sat, Oct 07, 2023 at 03:43:41PM +0800, Xu Yilun wrote:
> > On Fri, Oct 06, 2023 at 05:46:24PM -0500, Rob Herring wrote:
> > > Use preferred spi_get_device_match_data() instead of of_match_device() and
> > > spi_get_device_id() to get the driver match data. With this, adjust the
> > > includes to explicitly include the correct headers.
> > >
> > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> >
> > Acked-by: Xu Yilun <yilun.xu@xxxxxxxxx>
> >
> > Applied.
> >
> > >
> > >  static const struct spi_device_id altera_ps_spi_ids[] = {
> > > -   { "cyclone-ps-spi", CYCLONE5 },
> > > -   { "fpga-passive-serial", CYCLONE5 },
> > > -   { "fpga-arria10-passive-serial", ARRIA10 },
> > > +   { "cyclone-ps-spi", (uintptr_t)&c5_data },
> > > +   { "fpga-passive-serial", (uintptr_t)&c5_data },
> > > +   { "fpga-arria10-passive-serial", (uintptr_t)&a10_data },
>
> Sorry, one more. Should cast to kernel_ulong_t?

Either will work. uintptr_t is somewhat new in the kernel and
preferred now I think.

Rob




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux