Re: [PATCH v2 3/3] fpga: socfpga-a10: Fix incorrect return value of devm_regmap_init_mmio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Yangtao Li <frank.li@xxxxxxxx>
Subject: Re: [PATCH v2 3/3] fpga: socfpga-a10: Fix incorrect return value of devm_regmap_init_mmio
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 10 Jul 2023 16:11:35 +0200
Cc: Moritz Fischer <mdf@xxxxxxxxxx>, Wu Hao <hao.wu@xxxxxxxxx>, Xu Yilun <yilun.xu@xxxxxxxxx>, Tom Rix <trix@xxxxxxxxxx>, Alan Tull <atull@xxxxxxxxxxxxxxxxxxxxx>, Moritz Fischer <moritz.fischer@xxxxxxxxx>, linux-fpga@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20230710133830.65631-3-frank.li@vivo.com>
References: <20230710133830.65631-1-frank.li@vivo.com> <20230710133830.65631-3-frank.li@vivo.com>

On Mon, Jul 10, 2023 at 09:38:30PM +0800, Yangtao Li wrote:
> When devm_regmap_init_mmio fails, we should return PTR_ERR(priv->regmap)
> instead of -ENODEV.
> 
> Fixes: acbb910ae04b ("fpga-manager: Add Socfpga Arria10 support")

Why are you not also including a cc: stable@ tag here?

thanks,

greg k-h

Follow-Ups:
- Re: [PATCH v2 3/3] fpga: socfpga-a10: Fix incorrect return value of devm_regmap_init_mmio
  - From: Xu Yilun

References:
- [PATCH v2 1/3] fpga: fpga-mgr: altera-pr-ip: Convert to devm_platform_ioremap_resource()
  - From: Yangtao Li
- [PATCH v2 3/3] fpga: socfpga-a10: Fix incorrect return value of devm_regmap_init_mmio
  - From: Yangtao Li

Prev by Date: [PATCH v2 2/3] fpga: socfpga-a10: Convert to devm_platform_ioremap_resource()
Next by Date: Re: [PATCH v8 1/4] fpga: add an initial KUnit suite for the FPGA Manager
Previous by thread: [PATCH v2 3/3] fpga: socfpga-a10: Fix incorrect return value of devm_regmap_init_mmio
Next by thread: Re: [PATCH v2 3/3] fpga: socfpga-a10: Fix incorrect return value of devm_regmap_init_mmio
Index(es):
- Date
- Thread

[Index of Archives] [LM Sensors] [Linux Sound] [ALSA Users] [ALSA Devel] [Linux Audio Users] [Linux Media] [Kernel] [Gimp] [Yosemite News] [Linux Media]