On 2023-06-16 at 17:44:03 +0200, Marco Pagani wrote: > The suite tests the basic behaviors of the FPGA Bridge including > the functions that operate on a list of Bridges. ^ why uppercase? > > Signed-off-by: Marco Pagani <marpagan@xxxxxxxxxx> > --- > drivers/fpga/tests/fpga-bridge-test.c | 175 ++++++++++++++++++++++++++ > 1 file changed, 175 insertions(+) > create mode 100644 drivers/fpga/tests/fpga-bridge-test.c > > diff --git a/drivers/fpga/tests/fpga-bridge-test.c b/drivers/fpga/tests/fpga-bridge-test.c > new file mode 100644 > index 000000000000..fce67ac59a7c > --- /dev/null > +++ b/drivers/fpga/tests/fpga-bridge-test.c > @@ -0,0 +1,175 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * KUnit test for the FPGA Bridge > + * > + * Copyright (C) 2023 Red Hat, Inc. > + * > + * Author: Marco Pagani <marpagan@xxxxxxxxxx> > + */ > + > +#include <linux/types.h> > +#include <linux/module.h> > +#include <linux/device.h> > +#include <kunit/test.h> > +#include <linux/fpga/fpga-bridge.h> alphabetical order please. Others LGTM. Acked-by: Xu Yilun <yilun.xu@xxxxxxxxx>