On 2023-03-17 at 19:06:17 -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/fpga/xilinx-pr-decoupler.c:37:19: error: unused function 'xlnx_pr_decouple_read' [-Werror,-Wunused-function]
> static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d,
> ^
> This static function is not used, so remove it.
I prefer to move the description as the first section. If you agree, I
could do it before apply.
Acked-by: Xu Yilun <yilun.xu@xxxxxxxxx>
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
> ---
> drivers/fpga/xilinx-pr-decoupler.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> index 2d9c491f7be9..b6f18c07c752 100644
> --- a/drivers/fpga/xilinx-pr-decoupler.c
> +++ b/drivers/fpga/xilinx-pr-decoupler.c
> @@ -34,12 +34,6 @@ static inline void xlnx_pr_decoupler_write(struct xlnx_pr_decoupler_data *d,
> writel(val, d->io_base + offset);
> }
>
> -static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d,
> - u32 offset)
> -{
> - return readl(d->io_base + offset);
> -}
> -
> static int xlnx_pr_decoupler_enable_set(struct fpga_bridge *bridge, bool enable)
> {
> int err;
> --
> 2.27.0
>
