On 2023-02-07 02:05, Russ Weight wrote:
> Hi Marco,
>
> I've just started looking at this, but I have a couple of early comments below
>
Thanks for looking into this.
[...]
>> --- /dev/null
>> +++ b/drivers/fpga/tests/Kconfig
>> @@ -0,0 +1,15 @@
>> +config FPGA_KUNIT_TESTS
>> + tristate "FPGA KUnit tests" if !KUNIT_ALL_TESTS
>> + depends on FPGA && FPGA_REGION && FPGA_BRIDGE && KUNIT
>> + default KUNIT_ALL_TESTS
>> + help
>> + Builds unit tests for the FPGA subsystem. This option
>> + is not useful for distributions or general kernels,
>> + but only for kernel developers working on the FPGA
>> + subsystem and its associated drivers.
> These lines seem shorter than necessary. You can use up to 75
> characters per line.
>
I'll reflow the text in the next revision.
[...]
>> +static struct kunit_case fpga_test_cases[] = {
>> + KUNIT_CASE(fpga_base_test),
>> + KUNIT_CASE(fpga_pr_test),
>> + {},
>> +};
>> +
>> +static struct kunit_suite fpga_test_suite = {
>> + .name = "fpga-tests",
>> + .suite_init = fpga_suite_init,
>> + .test_cases = fpga_test_cases,
>> +};
>> +
>> +kunit_test_suite(fpga_test_suite);
>
> When I try to build with these patches, I get this error:
>>
>> ERROR: modpost: missing MODULE_LICENSE() in drivers/fpga/tests/fpga-tests.o
>
> I was able to fix it by adding this line at the bottom of the file:
>
>> MODULE_LICENSE("GPL");
>
> - Russ
>
Right, I forgot to add module info macros to the test suite module.
I'll add MODULE_LICENSE() in the next revision.
Thanks for the feedback,
Marco
