On Thu, Oct 20, 2022 at 02:26:10PM -0700, matthew.gerlach@xxxxxxxxxxxxxxx wrote: > From: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx> > > Add a Device Feature List (DFL) bus driver for the Altera > 16550 implementation of UART. ... > +#include <linux/bitfield.h> Where is device.h? > +#include <linux/dfl.h> > +#include <linux/io-64-nonatomic-lo-hi.h> User? > +#include <linux/kernel.h> Try to use what is really needed, yet this one may be still needed for something like ARRAY_SIZE(). > +#include <linux/module.h> > +#include <linux/serial.h> > +#include <linux/serial_8250.h> Missed types.h. ... > + ret = dfl_uart_get_params(dfl_dev, &uart); > + Redundant blank line. > + if (ret < 0) > + return dev_err_probe(dev, ret, "failed uart feature walk\n"); -- With Best Regards, Andy Shevchenko
