On 2022-08-27 at 14:46:37 +0000, Conor.Dooley@xxxxxxxxxxxxx wrote:
> On 27/08/2022 15:22, Xu Yilun wrote:
> > On 2022-08-25 at 10:41:55 -0400, Shaomin Deng wrote:
> >> Delete the repeated word "if" in comments.
> >
> > Please don't duplicate similar patches.
>
> It probably is not the right fix either...
>
> >
> >>
> >> Signed-off-by: Shaomin Deng <dengshaomin@xxxxxxxxxx>
> >> ---
> >> drivers/fpga/stratix10-soc.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> >> index 357cea58ec98..e4f2e83a615b 100644
> >> --- a/drivers/fpga/stratix10-soc.c
> >> +++ b/drivers/fpga/stratix10-soc.c
> >> @@ -285,7 +285,7 @@ static int s10_ops_write(struct fpga_manager *mgr, const char *buf,
> >>
> >> /*
> >> * Loop waiting for buffers to be returned. When a buffer is returned,
> >> - * reuse it to send more data or free if if all data has been sent.
> >> + * reuse it to send more data or free if all data has been sent.
>
> s/free if if/free it if
You are right. Thanks for your review.
>
> Not sure if the cdjrlc people are scripting these duplicate word removals
> but if so, they should check the output before sending b/c this seems to
> happen a lot.
They should. Scripting patches and sent without check is actually not a
good idea.
Thanks,
Yilun
>
> Thanks,
> Conor.
>
> >> */
> >> while (count > 0 || s10_free_buffer_count(mgr) != NUM_SVC_BUFS) {
> >> reinit_completion(&priv->status_return_completion);
> >> --
> >> 2.35.1
> >>
