On Thu, May 19, 2022 at 12:34:12PM +0800, tien.sung.ang@xxxxxxxxx wrote: > The send_buf is always used throughout the life-span of the CvP driver. > Hence, we thought it would be wise to just pre-allocate it one time > at the start of the probe/init. > It is also fine if we do it in the altera_cvp_write. The only issue we > see in this is that, a minor hit on the performance as you need to > then, allocate the buffer on every new CvP FPGA configuration write. > > As for STEP 16, the previous implementation checks the Error latch bit > which stores the previous transaction's result. If an error occurs > prior to this, the driver would throw an error which is not right. > The correct step is to just check for the current CvP error status > from the register. > Hope that is fine with you. Thanks Please comment inline in the mail, like others do. Thanks, Yilun
