[PATCH] fpga: Fix memory leak in build_info_create_dev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



platform_device_alloc() create a platform device object.
we should call platform_device_put() in error path to
release the resource.

Fixes: 543be3d8c999 ("fpga: add device feature list support")
Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
---
 drivers/fpga/dfl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c
index 599bb21d86af..f0b945bd975f 100644
--- a/drivers/fpga/dfl.c
+++ b/drivers/fpga/dfl.c
@@ -879,8 +879,10 @@ build_info_create_dev(struct build_feature_devs_info *binfo,
 	INIT_LIST_HEAD(&binfo->sub_features);
 
 	fdev->id = dfl_id_alloc(type, &fdev->dev);
-	if (fdev->id < 0)
+	if (fdev->id < 0) {
+		platform_device_put(fdev);
 		return fdev->id;
+	}
 
 	fdev->dev.parent = &binfo->cdev->region->dev;
 	fdev->dev.devt = dfl_get_devt(dfl_devs[type].devt_type, fdev->id);
-- 
2.25.1




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux