Hi Russ, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.18-rc4 next-20220422] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Russ-Weight/fpga-dfl-fix-the-kernel-warning-when-release-assign-ports-for-SRIOV/20220426-014949 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git af2d861d4cd2a4da5137f795ee3509e6f944a25b config: hexagon-randconfig-r041-20220425 (https://download.01.org/0day-ci/archive/20220426/202204260456.dOkQIjjg-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 1cddcfdc3c683b393df1a5c9063252eb60e52818) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/4b4db40cd1b608457d6e1fcf95443bd940d01f3c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Russ-Weight/fpga-dfl-fix-the-kernel-warning-when-release-assign-ports-for-SRIOV/20220426-014949 git checkout 4b4db40cd1b608457d6e1fcf95443bd940d01f3c # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/fpga/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/fpga/dfl.c:54: warning: cannot understand function prototype: 'struct dfl_dev_info ' drivers/fpga/dfl.c:74: warning: cannot understand function prototype: 'struct dfl_chardev_info ' drivers/fpga/dfl.c:154: warning: Function parameter or member 'fdata' not described in 'dfl_fpga_port_ops_get' drivers/fpga/dfl.c:154: warning: Excess function parameter 'pdev' description in 'dfl_fpga_port_ops_get' drivers/fpga/dfl.c:220: warning: Function parameter or member 'fdata' not described in 'dfl_fpga_check_port_id' drivers/fpga/dfl.c:220: warning: Excess function parameter 'pdev' description in 'dfl_fpga_check_port_id' drivers/fpga/dfl.c:716: warning: Function parameter or member 'revision' not described in 'dfl_feature_info' >> drivers/fpga/dfl.c:1509: warning: expecting prototype for __dfl_fpga_cdev_find_port(). Prototype was for __dfl_fpga_cdev_find_port_data() instead vim +1509 drivers/fpga/dfl.c 543be3d8c999b3 Wu Hao 2018-06-30 1490 5d56e117001996 Wu Hao 2018-06-30 1491 /** 5d56e117001996 Wu Hao 2018-06-30 1492 * __dfl_fpga_cdev_find_port - find a port under given container device 5d56e117001996 Wu Hao 2018-06-30 1493 * 5d56e117001996 Wu Hao 2018-06-30 1494 * @cdev: container device 5d56e117001996 Wu Hao 2018-06-30 1495 * @data: data passed to match function 5d56e117001996 Wu Hao 2018-06-30 1496 * @match: match function used to find specific port from the port device list 5d56e117001996 Wu Hao 2018-06-30 1497 * 5d56e117001996 Wu Hao 2018-06-30 1498 * Find a port device under container device. This function needs to be 5d56e117001996 Wu Hao 2018-06-30 1499 * invoked with lock held. 5d56e117001996 Wu Hao 2018-06-30 1500 * 5d56e117001996 Wu Hao 2018-06-30 1501 * Return: pointer to port's platform device if successful, NULL otherwise. 5d56e117001996 Wu Hao 2018-06-30 1502 * 5d56e117001996 Wu Hao 2018-06-30 1503 * NOTE: you will need to drop the device reference with put_device() after use. 5d56e117001996 Wu Hao 2018-06-30 1504 */ 4b4db40cd1b608 Xu Yilun 2022-04-25 1505 struct dfl_feature_dev_data * 4b4db40cd1b608 Xu Yilun 2022-04-25 1506 __dfl_fpga_cdev_find_port_data(struct dfl_fpga_cdev *cdev, void *data, 4b4db40cd1b608 Xu Yilun 2022-04-25 1507 int (*match)(struct dfl_feature_dev_data *, 4b4db40cd1b608 Xu Yilun 2022-04-25 1508 void *)) 5d56e117001996 Wu Hao 2018-06-30 @1509 { 4b4db40cd1b608 Xu Yilun 2022-04-25 1510 struct dfl_feature_dev_data *fdata; 5d56e117001996 Wu Hao 2018-06-30 1511 4b4db40cd1b608 Xu Yilun 2022-04-25 1512 list_for_each_entry(fdata, &cdev->port_dev_list, node) { 4b4db40cd1b608 Xu Yilun 2022-04-25 1513 if (match(fdata, data)) 4b4db40cd1b608 Xu Yilun 2022-04-25 1514 return fdata; 5d56e117001996 Wu Hao 2018-06-30 1515 } 5d56e117001996 Wu Hao 2018-06-30 1516 5d56e117001996 Wu Hao 2018-06-30 1517 return NULL; 5d56e117001996 Wu Hao 2018-06-30 1518 } 4b4db40cd1b608 Xu Yilun 2022-04-25 1519 EXPORT_SYMBOL_GPL(__dfl_fpga_cdev_find_port_data); 5d56e117001996 Wu Hao 2018-06-30 1520 -- 0-DAY CI Kernel Test Service https://01.org/lkp
