Hi Joe, Please find my response inline. > -----Original Message----- > From: Joe Perches <joe@xxxxxxxxxxx> > Sent: Saturday, April 16, 2022 10:29 PM > To: Nava kishore Manne <navam@xxxxxxxxxx>; mdf@xxxxxxxxxx; > hao.wu@xxxxxxxxx; yilun.xu@xxxxxxxxx; trix@xxxxxxxxxx; Michal Simek > <michals@xxxxxxxxxx>; linux-fpga@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; git > <git@xxxxxxxxxx> > Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues > > On Sat, 2022-04-16 at 19:07 +0530, Nava kishore Manne wrote: > > fixes the below checks reported by checkpatch.pl Lines should not end > > with a '(' > > Alignment should match open parenthesis > > in fpga-mgr: > Another possibillty would be to change the function arguments > > and > > in fpga-region: > Ideally keep the include declaration and definition styles synced > These changes are targeted to fix the checks reported by checkpatch.pl without touching the actual functionality. Regards, Navakishore.