> -----Original Message----- > From: Bagas Sanjaya <bagasdotme@xxxxxxxxx> > Sent: Wednesday, March 23, 2022 8:12 PM > To: Zhang, Tianfei <tianfei.zhang@xxxxxxxxx>; Wu, Hao <hao.wu@xxxxxxxxx>; > trix@xxxxxxxxxx; mdf@xxxxxxxxxx; Xu, Yilun <yilun.xu@xxxxxxxxx>; linux- > fpga@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx > Cc: corbet@xxxxxxx; rdunlap@xxxxxxxxxxxxx > Subject: Re: [PATCH v5 2/2] Documentation: fpga: dfl: add description of > Feature ID > > On 23/03/22 15.51, Tianfei Zhang wrote: > > +Individual DFL drivers are bound DFL devices based on Feature Type and > Feature ID. > > +The definition of Feature Type and Feature ID can be found: > > + > > +https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature- > > +ids.rst > > + > > This doesn't answer "What is Feature Type and Feature ID?" question. > I would like to see the answer and the feature list above in the kernel > documentation. Feature Type is the device type of feature device, currently, we only support FME device and Port device now. Feature ID means the ID of feature device. Individual DFL drivers are bound DFL devices based on Feature Type and Feature ID after DFL enumeration. I think those detail information are in DFL specification, and it don't need put everything in kernel documentation. And I think the feature list maintains by an extra git repository will be better, and the users want to add a new feature ID must submit a pull request for this repo to register the new ID. > > > +If you want to add a new feature ID for FPGA DFL feature device, you > > +must submit a pull request to register a feature ID for DFL. Here is the DFL > Feature ID Registry: > > + > > +https://github.com/OPAE/linux-dfl-feature-id > > + > > Please explain, in this document, the PR procedure regarding feature ID > registration. In this documentation, it has a chapter talk about the PR, pls see the " Partial Reconfiguration" chapter. On DFL perspective, PR is a FME private feature device, the Feature Type is "0" (0 means FME), the feature ID is 0x5. FME Partial Reconfiguration Sub Feature driver (see drivers/fpga/dfl-fme-pr.c) will be bound if it found a PR private feature device after DFL enumeration. > > -- > An old man doll... just what I always wanted! - Clara
