Hi Conor, Ivan, On Tue, Feb 15, 2022 at 05:37:04PM +0000, Conor Dooley wrote: > Hey Ivan, > Firstly thanks for the patch(es), stumbled across them today. > As you may know Microsemi has been acquired by Microchip, so > s/microsemi/microchip/ please. This would make the correct vendor > prefix for compatible strings "microchip". While you've said this is > for the PolarFire FPGA, there is prescendent for using "mpfs" for the > PolarFire SoC FPGA in the kernel - so if you could change the uses of > "polarfire" to "mpf" that'd be great. I personally don't have a strong opinion on hte microchip vs microsemi here. We have precedent with intel/altera. > > The current item on my own todo list is the opposite side of this, > reprogramming the FPGA via the system controller acting as a SPI > master for PolarFire SoC. > I will get back to you when I have a better idea of what (if any) code > can be made generic between both modes. In the meantime, I will get > together a setup to test SPI slave reprogramming of the PolarFire (SoC) > > Thanks, > Conor <conor.dooley@xxxxxxxxxxxxx> Thanks for chiming in. Always nice to have vendors help out reviewing. > > > Add support to the FPGA manager for programming Microsemi Polarfire > > FPGAs over slave SPI interface. > > > > Signed-off-by: Ivan Bornyakov <i.bornyakov@xxxxxxxxxxx> > > --- > > Changelog: > > v1 -> v2: fix printk formating > > > > drivers/fpga/Kconfig | 9 + > > drivers/fpga/Makefile | 1 + > > drivers/fpga/microsemi-spi.c | 366 +++++++++++++++++++++++++++++++++++ > > 3 files changed, 376 insertions(+) > > create mode 100644 drivers/fpga/microsemi-spi.c > > > --<snip>-- I'll take a closer look once the bot's complaints are addressed. Thanks, Moritz
