Re: [PATCH 0/4] FPGA Manager address unused variable warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 07, 2021 at 10:03:09AM +0800, Xu Yilun wrote:
> On Tue, Jul 06, 2021 at 09:28:37AM -0700, Tom Rix wrote:
> > 
> > On 7/1/21 8:54 PM, Moritz Fischer wrote:
> > > This patchset addresses a handful of warnings as result of_match_ids
> > > being not properly wrapped in #ifdef CONFIG_OF.
> > > 
> > > Moritz Fischer (4):
> > >    fpga: altera-freeze-bridge: Address warning about unused variable
> > >    fpga: xiilnx-spi: Address warning about unused variable
> > >    fpga: xilinx-pr-decoupler: Address warning about unused variable
> > >    fpga: zynqmp-fpga: Address warning about unused variable
> > > 
> > >   drivers/fpga/altera-freeze-bridge.c | 2 ++
> > >   drivers/fpga/xilinx-pr-decoupler.c  | 2 ++
> > >   drivers/fpga/xilinx-spi.c           | 2 ++
> > >   drivers/fpga/zynqmp-fpga.c          | 3 ++-
> > >   4 files changed, 8 insertions(+), 1 deletion(-)
> > 
> > I am not seeing these warnings, but it is still worth doing.
> > 
> > I think a few more files need this change.
> > 
> > altera-ps-spi.c, dfl-n3000-nios.c, altera-hps2fpga.c, stratix10-soc.c,
> > socfpga-a10.c, altera-fpga2sdram.c
> 
> dfl-n3000-nios is not using of_device_id, and doesn't need the change.
> 
> Thanks,
> Yilun
> 
> > 
> > Not needed for
> > 
> > altera-pr-ip-core-plat.c and ice40-spi.c
> > 
> > These have depends on OF in Kconfig.
> > 
> > Tom

Applied to for-next,

Moritz



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux