On Tue, Jul 06, 2021 at 06:52:09AM -0700, Tom Rix wrote: > > On 7/6/21 2:50 AM, Uwe Kleine-König wrote: > > The driver core ignores the return value of this callback because there > > is only little it can do when a device disappears. > > > > This is the final bit of a long lasting cleanup quest where several > > buses were converted to also return void from their remove callback. > > Additionally some resource leaks were fixed that were caused by drivers > > returning an error code in the expectation that the driver won't go > > away. > > > > With struct bus_type::remove returning void it's prevented that newly > > implemented buses return an ignored error code and so don't anticipate > > wrong expectations for driver authors. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > --- > > Hello, > > > > this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove > > return void" that is not yet applied, see > > https://lore.kernel.org/r/20210223090757.57604-1-u.kleine-koenig@xxxxxxxxxxxxxx. > > > > I tested it using allmodconfig on amd64 and arm, but I wouldn't be > > surprised if I still missed to convert a driver. So it would be great to > > get this into next early after the merge window closes. > > > > I send this mail to all people that get_maintainer.pl emits for this > > patch. I wonder how many recipents will refuse this mail because of the > > long Cc: list :-) > > > > Best regards > > Uwe > > > drivers/fpga/dfl.c | 4 +--- > Reviewed-by: Tom Rix <trix@xxxxxxxxxx> Reviewed-by: Xu Yilun <yilun.xu@xxxxxxxxx>
