On 6/15/21 1:08 AM, Wu, Hao wrote:
Subject: [PATCH v4 1/4] fpga: dfl: reorganize to subdir layout
From: Tom Rix <trix@xxxxxxxxxx>
Follow drivers/net/ethernet/ which has control configs
NET_VENDOR_BLA that map to drivers/net/ethernet/bla
Since fpgas do not have many vendors, drop the 'VENDOR' and use
FPGA_BLA.
Hi Tom,
Thanks for this patch. : )
DFL is not a vendor, but something can be shared/reused. It's possible that
other vendors reuse the same concepts and the drivers of DFL. If vendor
drivers need to be moved inside sub folders, then maybe it's better to
leave DFL in the parent folder?
xrt is also not a vendor, more a subdevice framework like dfl.
I am not sure what you mean by other dfl vendors can you give an example ?
There are several new subdirs
altera/
dfl/
lattice/
xilinx/
Each subdir has a Kconfig that has a new/reused
if FPGA_BLA
... existing configs ...
endif FPGA_BLA
Which is sourced into the main fpga/Kconfig
Each subdir has a Makefile whose transversal is controlled in the
fpga/Makefile by
obj-$(CONFIG_FPGA_BLA) += bla/
This is the dfl/ subdir part.
Create a dfl/ subdir
Move dfl-* files to it.
Add a Kconfig and Makefile
Because FPGA_DFL is now used in dfl/Kconfig in a if/endif
block, all the other configs in dfl/Kconfig implicitly depend
on FPGA_DFL. So the explicit dependence can be removed. Also
since FPGA_DFL depends on HAS_IOMEM, it can be removed from the
other configs.
Hm.. sounds like this change (remove HAS_IOMEM) is better to be split
into another patch. How do you think?
I'll drop this from the patchset so this so patchset does the one thing
of moving stuff around and do the HAS_IOMEM change after stuff settles.
Tom
Thanks
Hao
