On Mon, Jun 14, 2021 at 07:30:03PM +0200, Greg KH wrote:
> On Mon, Jun 14, 2021 at 10:09:03AM -0700, Moritz Fischer wrote:
> > From: Russ Weight <russell.h.weight@xxxxxxxxx>
> >
> > The stratix10-soc driver uses fpga_mgr_create() function and is therefore
> > responsible to call fpga_mgr_free() to release the class driver resources.
> > Add a missing call to fpga_mgr_free in the s10_remove() function.
> >
> > Signed-off-by: Russ Weight <russell.h.weight@xxxxxxxxx>
> > Reviewed-by: Xu Yilun <yilun.xu@xxxxxxxxx>
> > Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx>
> > ---
> > drivers/fpga/stratix10-soc.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> > index 657a70c5fc99..9e34bbbce26e 100644
> > --- a/drivers/fpga/stratix10-soc.c
> > +++ b/drivers/fpga/stratix10-soc.c
> > @@ -454,6 +454,7 @@ static int s10_remove(struct platform_device *pdev)
> > struct s10_priv *priv = mgr->priv;
> >
> > fpga_mgr_unregister(mgr);
> > + fpga_mgr_free(mgr);
> > stratix10_svc_free_channel(priv->chan);
> >
> > return 0;
> > --
> > 2.31.1
> >
>
> Does this fix a specific commit? Does it need a Fixes: and cc: stable
> line too?
Yes, I missed this. I think this should be:
Fixes: e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager
driver")
I can resend with Cc: stable
Thanks,
Moritz
