Looks good to me.
Reviewed-by: Xu Yilun <yilun.xu@xxxxxxxxx>
On Wed, Jun 09, 2021 at 03:11:28PM -0700, Russ Weight wrote:
> Remove the alt_pr_unregister() function; it is no longer used.
>
> Signed-off-by: Russ Weight <russell.h.weight@xxxxxxxxx>
> ---
> v2:
> - The first version of this patch was entitled:
> "fpga: altera-pr-ip: Remove function alt_pr_unregister". This version of the
> patch removes the alt_pr_unregister() function altogether, instead of just
> removing portions of it.
> ---
> drivers/fpga/altera-pr-ip-core.c | 10 ----------
> include/linux/fpga/altera-pr-ip-core.h | 1 -
> 2 files changed, 11 deletions(-)
>
> diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
> index 5b130c4d9882..dfdf21ed34c4 100644
> --- a/drivers/fpga/altera-pr-ip-core.c
> +++ b/drivers/fpga/altera-pr-ip-core.c
> @@ -199,16 +199,6 @@ int alt_pr_register(struct device *dev, void __iomem *reg_base)
> }
> EXPORT_SYMBOL_GPL(alt_pr_register);
>
> -void alt_pr_unregister(struct device *dev)
> -{
> - struct fpga_manager *mgr = dev_get_drvdata(dev);
> -
> - dev_dbg(dev, "%s\n", __func__);
> -
> - fpga_mgr_unregister(mgr);
> -}
> -EXPORT_SYMBOL_GPL(alt_pr_unregister);
> -
> MODULE_AUTHOR("Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx>");
> MODULE_DESCRIPTION("Altera Partial Reconfiguration IP Core");
> MODULE_LICENSE("GPL v2");
> diff --git a/include/linux/fpga/altera-pr-ip-core.h b/include/linux/fpga/altera-pr-ip-core.h
> index 0b08ac20ab16..a6b4c07858cc 100644
> --- a/include/linux/fpga/altera-pr-ip-core.h
> +++ b/include/linux/fpga/altera-pr-ip-core.h
> @@ -13,6 +13,5 @@
> #include <linux/io.h>
>
> int alt_pr_register(struct device *dev, void __iomem *reg_base);
> -void alt_pr_unregister(struct device *dev);
>
> #endif /* _ALT_PR_IP_CORE_H */
> --
> 2.25.1
