On Wed, Jun 09, 2021 at 09:25:31AM -0700, Russ Weight wrote: > > > On 6/9/21 8:37 AM, Xu Yilun wrote: > > On Tue, Jun 08, 2021 at 05:49:22PM -0700, Russ Weight wrote: > >> The altera-pr-ip driver uses the devm_fpga_mgr_register() call, so it is > >> unnecessary to call fpga_mgr_unregister(). Also, mgr is no longer stored > >> in the dev.driver_data, so remove the call to dev_get_drvdata(). > >> > >> alt_pr_unregister() is now an empty function, but is left intact because > >> it is an exported symbol. > > I don't see this function be called anywhere, so could we just remove > > it? > > > > Any impact we remove an exported symbol that is not used? > > Only if there are out-of-tree drivers that use it. What do other's think? Can we remove this? We don't care about out-of-tree drivers. Please remove it. - Moritz
