Looks good to me. Reviewed-by: Xu Yilun <yilun.xu@xxxxxxxxx> On Tue, Jun 08, 2021 at 05:49:23PM -0700, Russ Weight wrote: > The stratix10-soc driver uses fpga_mgr_create() function and is therefore > responsible to call fpga_mgr_free() to release the class driver resources. > Add a missing call to fpga_mgr_free in the s10_remove() function. > > Signed-off-by: Russ Weight <russell.h.weight@xxxxxxxxx> > --- > drivers/fpga/stratix10-soc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c > index 657a70c5fc99..9e34bbbce26e 100644 > --- a/drivers/fpga/stratix10-soc.c > +++ b/drivers/fpga/stratix10-soc.c > @@ -454,6 +454,7 @@ static int s10_remove(struct platform_device *pdev) > struct s10_priv *priv = mgr->priv; > > fpga_mgr_unregister(mgr); > + fpga_mgr_free(mgr); > stratix10_svc_free_channel(priv->chan); > > return 0; > -- > 2.25.1
