On 5/16/21 10:32 PM, Greg KH wrote: > On Sun, May 16, 2021 at 07:31:50PM -0700, Moritz Fischer wrote: >> From: Russ Weight <russell.h.weight@xxxxxxxxx> >> >> Extend the FPGA Security Manager class driver to >> include an update/filename sysfs node that can be used >> to initiate a secure update. The filename of a secure >> update file (BMC image, FPGA image, Root Entry Hash image, >> or Code Signing Key cancellation image) can be written to >> this sysfs entry to cause a secure update to occur. > Why is userspace responsible for triggering this? Passing a "filename" > into the kernel and having it do something with it is ripe for major > problems, please do not. > I am using the "request_firmware" framework, which accepts a filename and finds the firmware file under /lib/firmware. Is this not an acceptable use for request_firmware? - Russ
