Tom, On Mon, Jan 11, 2021 at 11:46:03AM -0800, Tom Rix wrote: [..] > I have been doing the first review in a couple of days after every patch landing. I appreciate your help with doing reviews. > I see some pretty good response from the developers to fix the issues raised. ... yet patches have been rejected. So it doesn't seem purely a matter of throughput? > But I do not see Moritz picking up the review until weeks later. I'll admit there are delays that happen, I have a dayjob as I pointed out in earlier conversations. Furthermore, just because I do not immediately send out an email does not mean I don't look at stuff. If people show up with 100kLOC patchsets that don't pass checkpatch, it'll take a while for me to even read up and understand what they're doing / trying to do. > This consistent delay in timely reviews is a bottleneck. As Greg pointed out even ones that were reviewed got rejected, so clearly the issue is with the quality and not the speed at which we send them on. > It would be good if the big first reviews could be done in parallel. Again depending how the patchsets are structured it will take me a while to process. Having them re-use existing infrastructure, following coding and submission guidelines will speed up the process. On a personal level, being told I'm too slow and not doing my job as maintainer doesn't exactly increase my motivation to get to it ... - Moritz
