> Subject: [PATCH] fpga: dfl: add missing platform_device_put in
> build_info_create_dev
>
> platform_device_put is missing when it fails to set fdev->id. Set
> a temp value to do sanity check.
will this case be covered already by build_info_free()?
Hao
>
> Fixes: 543be3d8c999 ("fpga: add device feature list support")
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Qinglang Miao <miaoqinglang@xxxxxxxxxx>
> ---
> drivers/fpga/dfl.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c
> index b450870b7..8958f0860 100644
> --- a/drivers/fpga/dfl.c
> +++ b/drivers/fpga/dfl.c
> @@ -877,10 +877,13 @@ build_info_create_dev(struct
> build_feature_devs_info *binfo,
>
> INIT_LIST_HEAD(&binfo->sub_features);
>
> - fdev->id = dfl_id_alloc(type, &fdev->dev);
> - if (fdev->id < 0)
> - return fdev->id;
> + int tmp_id = dfl_id_alloc(type, &fdev->dev);
> + if (tmp_id < 0) {
> + platform_device_put(fdev);
> + return tmp_id;
> + }
>
> + fdev->id = tmp_id;
> fdev->dev.parent = &binfo->cdev->region->dev;
> fdev->dev.devt = dfl_get_devt(dfl_devs[type].devt_type, fdev->id);
>
> --
> 2.23.0
