>>> + return -EINVAL; >>> + } >>> + >>> + ret = regmap_bulk_read(sec->m10bmc->regmap, reh_addr, >>> + hash, sha_num_bytes / stride); >> Assumes !(sha_num_bytes % stride) > Yes - good point. I'll add WARN_ON() here and for the CSK cancellation vectors. > In these cases, the size values are fixed, so a WARN_ON should be sufficient. Yes, thanks. Tom > Thanks, > - Russ >