On Sat, Oct 24, 2020 at 08:03:51AM -0700, Tom Rix wrote: > > On 10/23/20 1:45 AM, Xu Yilun wrote: > > This driver supports the ethernet retimers (Parkvale) for the Intel PAC > > (Programmable Acceleration Card) N3000, which is a FPGA based Smart NIC. > > Parkvale is a code name, it would be better if the public name was used. > > As this is a physical chip that could be used on other cards, > > I think the generic parts should be split out of intel-m10-bmc-retimer.c > > into a separate file, maybe retimer-c827.c This driver is not really a driver for the Parkvale. That driver is hidden away in the BMC. So we need to be a bit careful with the name, leaving it available for when somebody writes a real Linux driver for retimer. Andrew
