On Sat, Oct 10, 2020 at 03:09:49PM +0800, Xu Yilun wrote:
> In order to support MODULE_DEVICE_TABLE() for dfl device driver, this
> patch moves struct dfl_device_id to mod_devicetable.h
>
> Signed-off-by: Xu Yilun <yilun.xu@xxxxxxxxx>
> Signed-off-by: Wu Hao <hao.wu@xxxxxxxxx>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx>
> Signed-off-by: Russ Weight <russell.h.weight@xxxxxxxxx>
> Reviewed-by: Tom Rix <trix@xxxxxxxxxx>
> Acked-by: Wu Hao <hao.wu@xxxxxxxxx>
> Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx>
> ---
> v2: fix the order for the header file
> v3: rebase the patch for dfl bus name change
> v9: rebase the patch for dfl bus name changes back to "dfl"
> ---
> drivers/fpga/dfl.h | 13 +------------
> include/linux/mod_devicetable.h | 12 ++++++++++++
> 2 files changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> index ac373b1..549c790 100644
> --- a/drivers/fpga/dfl.h
> +++ b/drivers/fpga/dfl.h
> @@ -22,6 +22,7 @@
> #include <linux/interrupt.h>
> #include <linux/iopoll.h>
> #include <linux/io-64-nonatomic-lo-hi.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/uuid.h>
> @@ -526,18 +527,6 @@ enum dfl_id_type {
> };
>
> /**
> - * struct dfl_device_id - dfl device identifier
> - * @type: DFL FIU type of the device. See enum dfl_id_type.
> - * @feature_id: feature identifier local to its DFL FIU type.
> - * @driver_data: driver specific data.
> - */
> -struct dfl_device_id {
> - u16 type;
> - u16 feature_id;
> - unsigned long driver_data;
> -};
> -
> -/**
> * struct dfl_device - represent an dfl device on dfl bus
> *
> * @dev: generic device interface.
> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
> index 5b08a47..66e1405 100644
> --- a/include/linux/mod_devicetable.h
> +++ b/include/linux/mod_devicetable.h
> @@ -838,4 +838,16 @@ struct mhi_device_id {
> kernel_ulong_t driver_data;
> };
>
> +/**
> + * struct dfl_device_id - dfl device identifier
I still have no idea what "dfl" means. Please at the very least,
explain it here.
thanks,
greg k-h
