On Fri, 02 Oct 2020, Russ Weight wrote: > Add macros and definitions required by the MAX10 BMC > Security Engine driver. > > Signed-off-by: Russ Weight <russell.h.weight@xxxxxxxxx> > --- > v2: > - These functions and macros were previously distributed among > the patches that needed them. They are now grouped together > in a single patch containing changes to the Intel MAX10 BMC > driver. > - Added DRBL_ prefix to some definitions > - Some address definitions were moved here from the .c files that > use them. > --- > include/linux/mfd/intel-m10-bmc.h | 134 ++++++++++++++++++++++++++++++ > 1 file changed, 134 insertions(+) > > diff --git a/include/linux/mfd/intel-m10-bmc.h b/include/linux/mfd/intel-m10-bmc.h > index c8ef2f1654a4..880f907302eb 100644 > --- a/include/linux/mfd/intel-m10-bmc.h > +++ b/include/linux/mfd/intel-m10-bmc.h > @@ -13,6 +13,9 @@ > * m10bmc_raw_read - read m10bmc register per addr > + * m10bmc_raw_bulk_read - bulk read max10 registers per addr > + * m10bmc_raw_bulk_write - bulk write max10 registers per addr > + * m10bmc_raw_update_bits - update max10 register per addr > * m10bmc_sys_read - read m10bmc system register per offset > + * m10bmc_sys_update_bits - update max10 system register per offset > */ FWIW, I *hate* abstraction for the sake of abstraction. Please just use the Regmap API in-place instead. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog