On 10/4/20 11:01 AM, Russ Weight wrote: > > > On 10/2/20 8:15 PM, Randy Dunlap wrote: >> On 10/2/20 6:24 PM, Russ Weight wrote: >>> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig >>> index c534cc80f398..2380d36b08c7 100644 >>> --- a/drivers/fpga/Kconfig >>> +++ b/drivers/fpga/Kconfig >>> @@ -235,4 +235,15 @@ config IFPGA_SEC_MGR >>> region and for the BMC. Select this option to enable >>> updates for secure FPGA devices. >>> >>> +config IFPGA_M10_BMC_SECURE >>> + tristate "Intel MAX10 BMC security engine" >>> + depends on MFD_INTEL_M10_BMC && IFPGA_SEC_MGR >>> + help >>> + Secure update support for the Intel MAX10 board management >>> + controller. >>> + >>> + This is a subdriver of the Intel MAX10 board management controller >>> + (BMC) and provides support for secure updates for the BMC image, >>> + the FPGA image, the Root Entry Hashes, etc. >>> + >>> endif # FPGA >> Dagnabit, I need a bot to do this. >> >> Clean up the indentation in the Kconfig file. >> >> From Documentation/process/coding-style.rst, section 10: >> >> Lines under a ``config`` definition >> are indented with one tab, while help text is indented an additional two >> spaces. >> >> checkpatch should have found that issue. Did it not? > Sorry - I thought I had addressed the indentation errors after the first submission. > I'll fix it. > > I am running checkpatch.pl --strict, and I did not see a warning/error for this. OK, I looked at checkpatch.pl and I don't see any checks for that. I'll just work on a pseudo-bot then. thanks. -- ~Randy