On 2020/9/17 0:10, Moritz Fischer wrote: > Hi Yue, > > On Wed, Sep 16, 2020 at 10:25:36PM +0800, YueHaibing wrote: >> Fix sparse warning: >> >> drivers/fpga/dfl-n3000-nios.c:392:23: warning: >> symbol 'm10_n3000_info' was not declared. Should it be static? >> >> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> >> --- >> drivers/fpga/dfl-n3000-nios.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/fpga/dfl-n3000-nios.c b/drivers/fpga/dfl-n3000-nios.c >> index 5088f8f0e0cd..686813b59d33 100644 >> --- a/drivers/fpga/dfl-n3000-nios.c >> +++ b/drivers/fpga/dfl-n3000-nios.c >> @@ -389,7 +389,7 @@ static int n3000_nios_init_done_check(struct n3000_nios *ns) >> return ret; >> } >> >> -struct spi_board_info m10_n3000_info = { >> +static struct spi_board_info m10_n3000_info = { >> .modalias = "m10-n3000", >> .max_speed_hz = 12500000, >> .bus_num = 0, >> -- >> 2.17.1 >> > Can you resend this with a [PATCH v2] or [PATCH v2 next], neither > lore nor patchwork picks it up in its current form. > > This'll make sure it doesn't get lost. > > While at it could you change the first line to: > > "fpga: dfl: n3000-nios: Make m10_n3000_info static" Sure, will resend. > > Thanks for the patch, > Moritz > . >