> On 9/4/20 5:23 PM, Moritz Fischer wrote: > > Hi Russ, > > > > On Fri, Sep 04, 2020 at 04:52:54PM -0700, Russ Weight wrote: > >> Create the Intel Security Manager class driver. The security > >> manager provides interfaces to manage secure updates for the > >> FPGA and BMC images that are stored in FLASH. The driver can > >> also be used to update root entry hashes and to cancel code > >> signing keys. > >> > >> This patch creates the class driver and provides sysfs > >> interfaces for displaying root entry hashes, canceled code > >> signing keys and flash counts. > >> > >> Signed-off-by: Russ Weight <russell.h.weight@xxxxxxxxx> > >> Signed-off-by: Xu Yilun <yilun.xu@xxxxxxxxx> > > As for Reviewed-by tags I had seen on other patches in the series, I'd > > prefer for that to happen on public mailing lists. If Hao reviewed > > patches on some internal Intel list I won't know about it, so please > > have him properly Ack/Reviewed-by tag things on a public mailing list. > > Sure - I'll remove the Ack/Reviewed-by tags that were added internally > before I submit the next version of the patchset (except where Hao > re-adds them on the public list during this review cycle). Yes, please remove it to avoid confusing. I haven't looked at the latest code yet. Anyway, let's follow up this in public mailing list. Thanks Hao