On 3/9/2020 3:28 AM, Wu Hao wrote: > On Wed, Mar 04, 2020 at 10:33:10PM -0500, Dominic Chen wrote: >> +static const struct vm_operations_struct afu_vma_ops = { >> +#ifdef CONFIG_HAVE_IOREMAP_PROT >> + .access = generic_access_phys, >> +#endif /* CONFIG_HAVE_IOREMAP_PROT */ > To me, it's very clear for #ifdef - #end. So looks like this > /* CONFIG_HAVE_IOREMAP_PROT */ comments is not needed. > > Could you please remove it? > > Then > > Acked-by: Wu Hao <hao.wu@xxxxxxxxx> > > Thanks > Hao Thanks, sent out v4. Dominic