On 3/4/2020 10:09 PM, Moritz Fischer wrote:
>> +static const struct vm_operations_struct afu_vma_ops = {
>> +#ifdef CONFIG_HAVE_IOREMAP_PROT
>> + .access = generic_access_phys,
>> +#endif /* CONFIG_HAVE_IOREMAP_PROT */
> I remember there were issues in the past with modules and this, are
> those resolved?
Are you referring to the `generic_access_phys` symbol not being
exported? It looks like it became available to GPL modules starting with
kernel v3.12.
>> static int afu_mmap(struct file *filp, struct vm_area_struct *vma)
>> {
>> struct platform_device *pdev = filp->private_data;
>> @@ -488,6 +494,9 @@ static int afu_mmap(struct file *filp, struct vm_area_struct *vma)
>> !(region.flags & DFL_PORT_REGION_WRITE))
>> return -EPERM;
>>
>> + // Support debug access to the mapping
> Please use kernel style comments /* */ checkpatch.pl should catch this.
Hmm, I did run checkpatch.pl, though it contains `$allow_c99_comments =
1`. I'll send out v3 to fix this.
Thanks,
Dominic
