On Tue, Nov 6, 2018 at 3:58 PM Anatolij Gustschin <agust@xxxxxxx> wrote:
Hi Anatolij,
>
> Output VSE_PCIE_EXT_CAP_ID register address and expected register
> value in error message to give more info when analyzing issues
> with loaded periphery image.
>
> Signed-off-by: Anatolij Gustschin <agust@xxxxxxx>
> ---
> drivers/fpga/altera-cvp.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c
> index 381d0c42450f..08c0080092da 100644
> --- a/drivers/fpga/altera-cvp.c
> +++ b/drivers/fpga/altera-cvp.c
> @@ -413,7 +413,10 @@ static int altera_cvp_probe(struct pci_dev *pdev,
> */
> pci_read_config_word(pdev, VSE_PCIE_EXT_CAP_ID, &val);
> if (val != VSE_PCIE_EXT_CAP_ID_VAL) {
> - dev_err(&pdev->dev, "Wrong EXT_CAP_ID value 0x%x\n", val);
> + dev_err(&pdev->dev,
> + "Wrong VSE_PCIE_EXT_CAP_ID value 0x%04x at 0x%x, "
> + "expected: 0x%04x\n",
> + val, VSE_PCIE_EXT_CAP_ID, VSE_PCIE_EXT_CAP_ID_VAL);
This patch adds error print info which is printing out constants.
Wouldn't the user just be able to look at the source and know what was
expected? I may be missing something here.
Alan
> return -ENODEV;
> }
>
> --
> 2.17.1
>
