Hi Michal, On Fri, Oct 26, 2018 at 12:54 AM Michal Simek <michal.simek@xxxxxxxxxx> wrote: > > Ok, I had suspected you tested it and probably didn't run into issues, > > but just wanted to make sure we think about it. If you don't mind, swap > > it around as I suggested just to be safe. > > > > With that change feel free to add my Reviewed-by: Moritz Fischer > > <mdf@xxxxxxxxxx> in your v2. > > That clock can be used by something else that's why you didn't observe > any issue. Anyway I have no problem with reverting that setting back > that icap can be used. Ok, thanks for clarification, that was what I assumed :) > In general there should be synchronization mechanism for this. And also > driver "feature" not to enable access from icap for security reason. But > that's something what should be done in other patch. Yeah I'll have to look at remote notifications for FPGA managers soon-ish for another project as discussed at ELCE. Part of that would be synchronization I guess :) Umhh, based on the secure state read from CTRL_SEC_EN bit, or did you think along the lines of "xlnx,no-icap" property that your bootloader / dt would provide? Cheers, Moritz
