On Tue, Oct 16, 2018 at 10:54:28AM +0000, Cheng Fei Phung wrote: > This patch adds RIFFA PCIe linux driver for https://github.com/promach/riffa/tree/full_duplex/driver/linux > > TODO: > > 1) this driver needs further speed optimization although it can now achieve defined PCIe speed grade > 2) solve all the coding style errors from scripts/checkpatch.pl Can you please wrap your lines at 72 columns like your editor wanted you to? :) > > Signed-off-by: PHUNG CHENG FEI (feiphung@xxxxxxxxxxx) So close, you need to use '<' and '>' here, not '(' and ')' > > --- > Changes in v1: > - added full-duplex capability > > drivers/staging/riffa/Makefile | 157 +++ > drivers/staging/riffa/README.txt | 38 + > drivers/staging/riffa/circ_queue.c | 188 +++ > drivers/staging/riffa/circ_queue.h | 96 ++ > drivers/staging/riffa/riffa.c | 152 +++ > drivers/staging/riffa/riffa.h | 121 ++ > drivers/staging/riffa/riffa_driver.c | 1633 ++++++++++++++++++++++++++ > drivers/staging/riffa/riffa_driver.h | 131 +++ > 8 files changed, 2516 insertions(+) > create mode 100644 drivers/staging/riffa/Makefile > create mode 100644 drivers/staging/riffa/README.txt > create mode 100644 drivers/staging/riffa/circ_queue.c > create mode 100644 drivers/staging/riffa/circ_queue.h > create mode 100644 drivers/staging/riffa/riffa.c > create mode 100644 drivers/staging/riffa/riffa.h > create mode 100644 drivers/staging/riffa/riffa_driver.c > create mode 100644 drivers/staging/riffa/riffa_driver.h This does not actually add the driver to the kernel build process at all. How are you testing this? You need to hook it up by adding a Kconfig file and touching the drivers/staging/Kconfig and drivers/staging/Makefile files to add your code to the build system. As it is, this doesn't work at all :( And none of your code has any tabs in it at all. You should at least fix that up first, otherwise the very first patch people are going to be forced to send will be to replace all lines in all of these files with that type of modification. It is better if you do that first. thanks, greg k-h
