Hi Alan, Thanks for the review... <Snip> > Another minor thing. > > > + > > > +/************************************************************** > ****** > > +********/ > > Let's keep the coding style consistent by not having Sure will fix in v4... > '***************************' > > > +/** > > + * > > Also, you don't need /** followed by '*', just take out the essentially blank > line here, please. Sure will fix in v4... Regards, Kedar. > > > + * Generates a Type 2 packet header that reads back the requested > > +Configuration > > + * register. > > + * > > + * @param OpCode is the read/write operation code. > > + * @param Size is the size of the word to be read. > > + * > > + * @return Type 2 packet header to read the specified register > > + * > > + * @note None. > > + * > > + > > > +*************************************************************** > ****** > > +********/ static int zynq_type2_pkt(u8 OpCode, u32 Size) { > > Thanks, > Alan ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f