On Sat, Feb 8, 2025, at 10:29, oushixiong1025@xxxxxxx wrote: > From: Shixiong Ou <oushixiong@xxxxxxxxxx> > > 1. The device_remove_file() need to be called when driver is removing. > 2. The device_remove_file() need to be called if the call to > device_create_file() fails. This should probably use device_add_group() instead of individual files to simplify both creation and removal. It would also avoid the bug you introduced that gcc warns about. Arnd