Hi Rob Thank you for your review > > index e05e528ffc6f7..a25f216b2513c 100644 > > --- a/drivers/media/platform/xilinx/xilinx-tpg.c > > +++ b/drivers/media/platform/xilinx/xilinx-tpg.c > > @@ -13,6 +13,7 @@ > > #include <linux/gpio/consumer.h> > > #include <linux/module.h> > > #include <linux/of.h> > > +#include <linux/of_graph.h> > > #include <linux/platform_device.h> > > #include <linux/xilinx-v4l2-controls.h> > > > > @@ -744,7 +745,7 @@ static int xtpg_parse_of(struct xtpg_device *xtpg) > > } > > > > This function is looping over port nodes, why don't you make it use > for_each_of_graph_port()? Yes, indeed. Will fix in v5 Thank you for your help !! Best regards --- Kuninori Morimoto
