Hi Tomi > > +/** > > + * of_graph_get_next_port_endpoint() - get next endpoint node in port. > > + * If it reached to end of the port, it will return NULL. > > + * @port: pointer to the target port node > > + * @endpoint: current endpoint node, or NULL to get first > > + * > > + * Return: An 'endpoint' node pointer with refcount incremented. Refcount > > + * of the passed @prev node is decremented. > > + */ > > Same issues here too. No "prev" parameter, and I suggest using > "previous", not "current", to be consistent with > of_graph_get_next_endpoint(). (or alternatively, change > of_graph_get_next_endpoint()). > > Oh, the declaration of the function uses "prev", but the implementation > "endpoint". Please make the naming same. Will fix in v2. But it will use "prev" for param same as of_graph_get_next_endpoint() > > +/** > > + * for_each_of_graph_port_endpoint - iterate over every endpoint in a port node > > + * @parent: parent device or ports node > > Hmm, shouldn't the parent be a port node? Thanks, will fix in v2 Thank you for your help !! Best regards --- Kuninori Morimoto
