Hi Florian, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-tip/drm-tip linus/master v6.9-rc6 next-20240503] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Florian-Fainelli/fbdev-Have-CONFIG_FB_NOTIFY-be-tristate/20240504-033139 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20240503192858.103640-1-florian.fainelli%40broadcom.com patch subject: [PATCH] fbdev: Have CONFIG_FB_NOTIFY be tristate config: i386-randconfig-015-20240504 (https://download.01.org/0day-ci/archive/20240504/202405042242.iXLDu4Xj-lkp@xxxxxxxxx/config) compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240504/202405042242.iXLDu4Xj-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202405042242.iXLDu4Xj-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): ld: drivers/leds/trigger/ledtrig-backlight.o: in function `bl_trig_deactivate': >> drivers/leds/trigger/ledtrig-backlight.c:128:(.text+0x136): undefined reference to `fb_unregister_client' ld: drivers/leds/trigger/ledtrig-backlight.o: in function `bl_trig_activate': >> drivers/leds/trigger/ledtrig-backlight.c:117:(.text+0x1aa): undefined reference to `fb_register_client' vim +128 drivers/leds/trigger/ledtrig-backlight.c e4786ba0db7b11 drivers/leds/trigger/ledtrig-backlight.c Uwe Kleine-König 2018-07-02 100 2282e125a406e0 drivers/leds/trigger/ledtrig-backlight.c Uwe Kleine-König 2018-07-02 101 static int bl_trig_activate(struct led_classdev *led) 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 102 { 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 103 int ret; 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 104 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 105 struct bl_trig_notifier *n; 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 106 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 107 n = kzalloc(sizeof(struct bl_trig_notifier), GFP_KERNEL); e4786ba0db7b11 drivers/leds/trigger/ledtrig-backlight.c Uwe Kleine-König 2018-07-02 108 if (!n) e4786ba0db7b11 drivers/leds/trigger/ledtrig-backlight.c Uwe Kleine-König 2018-07-02 109 return -ENOMEM; e4786ba0db7b11 drivers/leds/trigger/ledtrig-backlight.c Uwe Kleine-König 2018-07-02 110 led_set_trigger_data(led, n); 9f9455ae710786 drivers/leds/ledtrig-backlight.c Janusz Krzysztofik 2011-01-12 111 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 112 n->led = led; 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 113 n->brightness = led->brightness; 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 114 n->old_status = UNBLANK; 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 115 n->notifier.notifier_call = fb_notifier_callback; 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 116 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 @117 ret = fb_register_client(&n->notifier); 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 118 if (ret) 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 119 dev_err(led->dev, "unable to register backlight trigger\n"); 2282e125a406e0 drivers/leds/trigger/ledtrig-backlight.c Uwe Kleine-König 2018-07-02 120 2282e125a406e0 drivers/leds/trigger/ledtrig-backlight.c Uwe Kleine-König 2018-07-02 121 return 0; 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 122 } 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 123 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 124 static void bl_trig_deactivate(struct led_classdev *led) 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 125 { e4786ba0db7b11 drivers/leds/trigger/ledtrig-backlight.c Uwe Kleine-König 2018-07-02 126 struct bl_trig_notifier *n = led_get_trigger_data(led); 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 127 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 @128 fb_unregister_client(&n->notifier); 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 129 kfree(n); 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 130 } 132e9306beedd0 drivers/leds/ledtrig-backlight.c Rodolfo Giometti 2008-10-13 131 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki