On Tue, Jul 25, 2023 at 09:53:16PM +0200, Javier Martinez Canillas wrote: > Thomas Zimmermann <tzimmermann@xxxxxxx> writes: > > > Hi > > > > [...] > > >> > >> Yes. I meant to move drivers/video/logo/ to drivers/fbdev/core/logo and to > >> source its Kconfig from drivers/fbdev/core/Kconfig, since it now depends > >> on FB_CORE. > > > > No, please rather leave it where it is. There's no code dependencies to > > the fbdev core; it merely depends on the Kconfig token. > > > > Sure, fine by me. But I disagree that there's merely a Kconfig dependency. > The include/linux/linux_logo.h header declares both fb_find_logo() and > fb_append_extra_logo(). > > The fb_find_logo() function is defined in drivers/video/logo.c while the > fb_append_extra_logo() is in drivers/video/fbdev/core/fbmem.c, even though > only arch/powerpc/platforms/cell/spu_base.c uses fb_append_extra_logo(). > > So there's a relationship already between logo and fbdev/core, that's why > I wondered if would make sense to also move drivers/video/logo.c to have > both functions in there. Or as I also suggested on irc - to pull out all the logo stuff from fbmem and put it in video/logo/ With a bit of refactoring to make it obvious this is logo stuff and maybe avoid some of the ifdeffery in the code of the users. Sam
