On Mon, Jul 10, 2023 at 09:20:01PM +0800, Yangtao Li wrote: > These lables are redundant and don't do anything, let's remove it. s/lable/label/ here an in the subject line. Are you using this driver, or did you just stumble over it while looking for some janitorial todo? If the former, I suggest you look into the drm driver (imx-lcdc) instead. Having said that, I'm not sure this cleanup is really valuable. While a single jump target position has several names, ret = imxfb_of_read_mode(&pdev->dev, display_np, fbi->mode); of_node_put(display_np); if (ret) goto failed_of_parse; is more obvious correct than ret = imxfb_of_read_mode(&pdev->dev, display_np, fbi->mode); of_node_put(display_np); if (ret) goto failed_init; . *shrug* Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
